Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cmake warning about future support removal #1579

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

rndx21033
Copy link
Contributor

Fix warning about CMake future removal for support of versions < 3.5

@tigercosmos
Copy link
Collaborator

@rndx21033 what warnings?

@rndx21033
Copy link
Contributor Author

rndx21033 commented Sep 13, 2024

@rndx21033 what warnings?

cmake --version

cmake version 3.28.1

CMake suite maintained and supported by Kitware (kitware.com/cmake).

cmake -S . -B build

#....various cmake output....
#....followed by this:

CMake Deprecation Warning at 3rdParty/MemPlumber/MemPlumber/CMakeLists.txt:1 (cmake_minimum_required):
Compatibility with CMake < 3.5 will be removed from a future version of
CMake.

Update the VERSION argument value or use a ... suffix to tell
CMake that the project does not need compatibility with older versions.

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.90%. Comparing base (4af4b8b) to head (3cb14b4).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1579      +/-   ##
==========================================
- Coverage   82.91%   82.90%   -0.01%     
==========================================
  Files         273      273              
  Lines       46261    46261              
  Branches     9412     9492      +80     
==========================================
- Hits        38356    38353       -3     
- Misses       7049     7073      +24     
+ Partials      856      835      -21     
Flag Coverage Δ
fedora39 74.51% <ø> (-0.01%) ⬇️
macos-12 80.88% <ø> (ø)
macos-13 80.30% <ø> (+<0.01%) ⬆️
macos-14 80.22% <ø> (ø)
mingw32 70.29% <ø> (-0.02%) ⬇️
mingw64 70.24% <ø> (-0.05%) ⬇️
npcap 84.75% <ø> (-0.09%) ⬇️
rhel94 74.28% <ø> (-0.01%) ⬇️
ubuntu2004 57.84% <ø> (+<0.01%) ⬆️
ubuntu2004-zstd 57.97% <ø> (-0.03%) ⬇️
ubuntu2204 74.22% <ø> (+<0.01%) ⬆️
ubuntu2204-icpx 58.39% <ø> (-0.04%) ⬇️
ubuntu2404 74.45% <ø> (-0.03%) ⬇️
unittest 82.90% <ø> (-0.01%) ⬇️
windows-2019 84.87% <ø> (-0.02%) ⬇️
windows-2022 84.87% <ø> (-0.02%) ⬇️
winpcap 84.85% <ø> (ø)
xdp 49.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tigercosmos tigercosmos merged commit 0aa0c83 into seladb:dev Sep 19, 2024
40 checks passed
tigercosmos pushed a commit to tigercosmos/PcapPlusPlus that referenced this pull request Sep 24, 2024
@rndx21033 rndx21033 deleted the dev-fix-cmakewarning branch October 31, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants